Re nest parallelize #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
blocked by qiime2/qiime2#790 |
|
Is this PR related or should I open a new issue? |
|
@colinbrislawn this PR is related |
|
@ebolyen and @gregcaporaso now that qiime2/qiime2#790 is merged this ought to work as intended |
gregcaporaso
force-pushed
the
re-nest-parallelize
branch
from
88bd9a4 to
597617c
Compare
gregcaporaso
force-pushed
the
re-nest-parallelize
branch
from
597617c to
70c7a83
Compare
|
@Oddant1, fyi I rebased to test with the most recent environment files - that's what the force-pushes are, in case you're wondering. |
gregcaporaso
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
All changes look right, thanks @Oddant1! Just doing some local testing of serial v parallel runs - if all good there, this is ready for merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re nest the pipelines so things will parallelize